-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expression params #323
base: main
Are you sure you want to change the base?
Expression params #323
Conversation
What bug is the workaround for? |
This one: mlr-org/mlr3#581 The "workaround" is having the function object inherit the class "function", so it is arguable if that is maybe the way it is supposed to be. |
hi martin, thx a lot for taking the time to look at this. but.... you are kinda making it harder than it should be to review this?
|
Furthermore, maybe not essential now (If this works we should REALLY try to use it), but: probably some sugar / shortcut might be needed? |
See how mtry as the Learner sees it is
3
, derived from its$values$mtry
, which iswith
x
set to 0.78.task
is, by default, taken from the environment in which theLearner
callsself$param_set$get_values(tags = "train")
.I am not yet completely happy with this solution:
dynGet()
, or the like.Some problems that arose: what should the behaviour of
ParamSetCollection$get_valuess()
be when the context is not fulfilled?PSC$get_values()
just not be called?