Fix MASK alpha mode rendering issues #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Updated get_trimesh_props to copy alphaMode for PBRMaterial • Updated mesh.frag to discard fragments with alpha <= alphaThreshold • Added new define: IS_MASK_ALPHA_MODE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experiencing issues rendering textures with the
MASKalpha mode. Some faces would render through the transparent sections and some simply wouldn't. I tracked this down to being caused by the depth buffer treating the transparent sections as opaque.Here is an example of the depth buffer for a masked texture using the current version of pyrender:
And the same texture after my changes:
I have added a check in
mesh.fragto discard the fragment if the alpha is less than the material's alpha cutoff. I have also added a new defineIS_MASK_ALPHA_MODEspecifying if the alpha mode is set toMASK.Thank you for taking the time to read, let me know if you have any suggestions!