Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobilecoind: add tx_out_view_key_match api #4016

Conversation

eranrund
Copy link
Contributor

@eranrund eranrund commented Nov 8, 2024

Motivation

We needed to have the ability to do view key matching on some txo data and we are already running mobilecoind, so instead of having to link in a lot of the mobilecoin Rust code, we added an endpoint to mobilecoind to do this.

We're using it and can confirm it works, and we also added a unit test for it.

Thanks!

@eranrund eranrund changed the base branch from main to release/v6.1 November 8, 2024 20:54
Copy link
Contributor

@cbeck88 cbeck88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@holtzman holtzman changed the base branch from release/v6.1 to land/v6.1/mobilecoind-view-key-match-api November 13, 2024 21:14
Copy link
Contributor

@holtzman holtzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution.

@eranrund @cbeck88 temporarily landing this PR into a branch in the main repo so that it can be PR'ed to release/v6.1 after getting a full CI/CD run.

@holtzman holtzman merged commit c119902 into mobilecoinfoundation:land/v6.1/mobilecoind-view-key-match-api Nov 13, 2024
33 of 49 checks passed
@eranrund
Copy link
Contributor Author

Thank you @holtzman !

holtzman added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants