Fix include paths for wasm build #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
github_actions
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
changed the title
Codecov Report
@@ Coverage Diff @@
## nick/fix-beta-clippy #395 +/- ##
========================================================
+ Coverage 88.33% 88.42% +0.09%
========================================================
Files 40 40
Lines 5639 5633 -6
========================================================
Hits 4981 4981
+ Misses 658 652 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions
bot
added
size/M
nick-mobilecoin
force-pushed
the
nick/fix-wasm-build
branch
from
e5f34b5
to
be4b329
Compare
Previously the sys crates were using the vendored headers, but not the vendored `tlibc` directory. This would result in errors relating to `time.h` when building the sys crates on some platforms. Now the vendored `tlibc` is included when building the sys crates.
nick-mobilecoin
force-pushed
the
nick/fix-wasm-build
branch
from
be4b329
to
8e0d16a
Compare
eranrund
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing
tlibcinclude directory for sys cratesPreviously the sys crates were using the vendored headers, but not the
vendored
tlibcdirectory. This would result in errors relating totime.hwhen building the sys crates on some platforms. Now thevendored
tlibcis included when building the sys crates.