Add ConstantTimeEq impl for wrapped byte structs
#407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types that wrap a byte struct,
`pub struct foo { pub bytes: [u8; some_size] }`,
now implement the `ConstantTimeEq` trait.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
github-actions
bot
added
dependencies
nick-mobilecoin
requested review from
dolanbernard
and removed request for
a team
nick-mobilecoin
commented
Aug 22, 2023
Codecov Report
@@ Coverage Diff @@
## nick/serialize-quote-nonce #407 +/- ##
==============================================================
- Coverage 88.43% 88.39% -0.05%
==============================================================
Files 40 40
Lines 5640 5643 +3
==============================================================
Hits 4988 4988
- Misses 652 655 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dolanbernard
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types that wrap a byte struct,
pub struct foo { pub bytes: [u8; some_size] },now implement the
ConstantTimeEqtrait.