-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix newer clippy warnings #491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @nick-mobilecoin and the rest of your teammates on Graphite |
nick-mobilecoin
changed the base branch from
nick/fix-elliptic-curve-dep
to
main
March 22, 2024 14:53
nick-mobilecoin
force-pushed
the
nick/fix-clippy
branch
from
March 22, 2024 14:53
c3a50f9
to
1d8c18f
Compare
nick-mobilecoin
commented
Mar 22, 2024
nick-mobilecoin
force-pushed
the
nick/fix-clippy
branch
2 times, most recently
from
March 22, 2024 15:00
abe36ed
to
0797fd7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 88.86% 88.37% -0.49%
==========================================
Files 40 40
Lines 5721 5266 -455
==========================================
- Hits 5084 4654 -430
+ Misses 637 612 -25 ☔ View full report in Codecov by Sentry. |
nick-mobilecoin
force-pushed
the
nick/fix-clippy
branch
from
March 22, 2024 15:40
0797fd7
to
10a0d7c
Compare
nick-mobilecoin
force-pushed
the
nick/fix-clippy
branch
from
March 22, 2024 15:43
10a0d7c
to
911c753
Compare
See #490 for the fix for the cargo deny failure |
Merged
holtzman
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.