InvalidDefinitionDescription Rule Check #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daghack
changed the title
daghack
force-pushed
the
invalid-definition-description-check
branch
from
f2b6718
to
5e1ca11
Compare
daghack
force-pushed
the
invalid-definition-description-check
branch
from
5e1ca11
to
91470a3
Compare
|
@dvdksn Do you mind taking a look at the docs here and shooting me suggestions? I'm not at all happy with them, and I'd love your input. 😍 |
dvdksn
reviewed
Aug 8, 2024
frontend/dockerfile/linter/docs/InvalidDefinitionDescription.md
Outdated
Show resolved
Hide resolved
dvdksn
reviewed
Aug 8, 2024
dvdksn
reviewed
Aug 8, 2024
frontend/dockerfile/linter/docs/InvalidDefinitionDescription.md
Outdated
Show resolved
Hide resolved
daghack
force-pushed
the
invalid-definition-description-check
branch
2 times, most recently
from
5218f04
to
ba68288
Compare
tonistiigi
reviewed
Aug 12, 2024
frontend/dockerfile/docs/rules/invalid-definition-description.md
Outdated
Show resolved
Hide resolved
daghack
force-pushed
the
invalid-definition-description-check
branch
7 times, most recently
from
f060309
to
9c3fcea
Compare
github-actions
bot
added
area/source
area/worker
and removed
area/llb
area/hack
daghack
force-pushed
the
invalid-definition-description-check
branch
from
fe59af0
to
4270ddf
Compare
|
@tonistiigi Can I get a review? |
Signed-off-by: Talon Bowler <[email protected]>
Signed-off-by: Talon Bowler <[email protected]>
daghack
force-pushed
the
invalid-definition-description-check
branch
from
4270ddf
to
6fefbd4
Compare
tonistiigi
approved these changes
Oct 7, 2024
|
@dvdksn PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5169
Implements a check around definition description comments used by
--call=outlineand--call=targets.