Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test races (carry #48) #89

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 19, 2022

carries: #48
closes #48

@thaJeztah
Copy link
Member Author

CI failure is unrelated; will be fixed by #90

@thaJeztah
Copy link
Member Author

@dims PTAL 🤗

@dims
Copy link
Collaborator

dims commented Dec 19, 2022

hmm, 90 needs one more approval before we can land that and make this go green here

@thaJeztah
Copy link
Member Author

hmm, 90 needs one more approval before we can land that and make this go green here

I, erm, went slightly ahead and got that one in to fix CI 😅 😇

@dmcgowan ptal

@thaJeztah
Copy link
Member Author

FWIW; I just noticed that #86 also has a fix for this, so we could choose to take that one as well (I guess either approach would work)

@dmcgowan
Copy link
Member

Either is fine, #86 is a bit bigger and think it needs some validation

@aojea
Copy link

aojea commented Feb 14, 2023

/lgtm

I'm going to close #86 since it should no longer needed

Signed-off-by: Derek McGowan <[email protected]> (github: dmcgowan)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the carry_48_fix_unit_test_race branch from 04c4b9a to 31503b1 Compare June 21, 2024 13:35
@thaJeztah
Copy link
Member Author

@dmcgowan I saw you merged another PR; I rebased this one again to get a fresh run of CI 👍

@dmcgowan dmcgowan merged commit 478d001 into moby:master Jun 21, 2024
4 checks passed
@thaJeztah thaJeztah deleted the carry_48_fix_unit_test_race branch June 21, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants