Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify network allocation on creating network #2914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Verify network allocation on creating network #2914

wants to merge 1 commit into from

Commits on Nov 25, 2019

  1. Verify network allocation on creating network 

    Current network allocation is run asynchronously with network (object) creation, when a user specifies an overlapped subnet, the network creation succeeds but this network is useless with empty IPAM config.

This commit makes network creation use a channel to wait for the result of network allocation from Allocator before return.
Because of this change, some _test.go files are modified.

Also added TestCreateNetworkOverlapIP to network_test.go.

Remove duplicated line in "make coverage" of direct.mk.

Signed-off-by: Xinfeng Liu <[email protected]>
    @xinfengliu
    xinfengliu committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    917f30d View commit details
    Browse the repository at this point in the history