Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 18.0.0 #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Release 18.0.0 #11

wants to merge 3 commits into from

Conversation

ralphm
Copy link
Member

@ralphm ralphm commented Mar 7, 2018

No description provided.

@ralphm
Copy link
Member Author

ralphm commented Mar 7, 2018

This branch is for doing an actual release for Vör. I've already created and uploaded a first release candidate on PyPI.

@ralphm ralphm mentioned this pull request Mar 8, 2018
Open
twonds
twonds reviewed Mar 8, 2018
View reviewed changes
vor/__init__.py
@@ -0,0 +1,11 @@
"""
Wokkel.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't wokkel ;)

twonds
twonds approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@twonds twonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you need to fix the wokkel comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twonds twonds twonds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphm @twonds