Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theseus): Update to Tauri v2 #2178

Merged
merged 20 commits into from
Aug 27, 2024

Conversation

Norbiros
Copy link
Contributor

@Norbiros Norbiros commented Aug 19, 2024

This PR updates codebase to use Tauri v2 and cleans up some code.

Progress

Closes

Resolves #1230
Resolves #214
Resolves #995
Resolves #520
Resolves #239
Resolves #867
Resolves #991
Resolves #1065

@Norbiros Norbiros force-pushed the feat/theseus/tauri-v2 branch 2 times, most recently from a5c458a to ad3ebb4 Compare August 22, 2024 10:30
Copy link

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting rid of the git dependencies here, it'll help a lot with packaging! Please let me know if there's anything you need help with :)

@Norbiros Norbiros force-pushed the feat/theseus/tauri-v2 branch 2 times, most recently from c98745a to ad30502 Compare August 24, 2024 09:11
@Norbiros Norbiros marked this pull request as ready for review August 24, 2024 11:24
@Norbiros
Copy link
Contributor Author

I believe most of the work is complete. I'll clean up the plugins in a future PR. I've tested the app only on Linux, so it would be great if someone could test it on other platforms and confirm that it works.

@Geometrically, please rename TAURI_PRIVATE_KEY to TAURI_SIGNING_PRIVATE_KEY for workflow to pass.

@Geometrically Geometrically merged commit d6a72fb into modrinth:main Aug 27, 2024
1 check failed
@Norbiros Norbiros deleted the feat/theseus/tauri-v2 branch August 27, 2024 19:52
@jebibot
Copy link

jebibot commented Aug 28, 2024

Please note in @tauri-apps/[email protected], open returns a FileResponse object instead of a string for the file selection. However, this behavior is reverted in tauri-apps/plugins-workspace@448846b#diff-7d692d06c9825847f618edbc332bca2f7196f2495e86f2a80825d0d9b76a6d51, which has not been released yet, so there would be no need to change the code, but the file selection wouldn't work until a new version is published and updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment