Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent alignment for 'project settings page confirmation' buttons #2524

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Khazoda
Copy link
Contributor

@Khazoda Khazoda commented Oct 19, 2024

Currently, project pages such as General, Tags, Links etc. have inconsistent locations for the 'Save Changes' button:

Right Side: General, Tags, Links
Left Side: Description, License

This PR changes 1 line of css for the .button-group class, unifying the buttons on the left side of the button group.

Things to consider:

  • I haven't tested the entire site to check where else .button-group is used. If it's used in unexpected places there may be unforseen layout shifts from this PR (Scoping the styles to each page would likely be preferable if this is the case)
  • Moving the buttons to the left hand side was an arbitrary decision on my part. They can just as easily be on the right if that would be preferred. (Although it definitely looks better on the left side for the Links page):

Button on the right (current live site)

image

Button on the left

image

@Khazoda
Copy link
Contributor Author

Khazoda commented Oct 19, 2024

I think it'd be best to scope the justify-content: flex-start style for .button-group to the project editing pages.
Changing it globally would impact many locations which shouldn't be impacted e.g.
image

@Khazoda Khazoda marked this pull request as draft October 19, 2024 18:18
@Khazoda Khazoda marked this pull request as ready for review October 20, 2024 09:47
@Khazoda
Copy link
Contributor Author

Khazoda commented Oct 20, 2024

Styles are now scoped to
[type]/[id]/settings/index
[type]/[id]/settings/links
[type]/[id]/settings/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant