fix: add optional check while accessing webpack internals #2968 #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5c6ec74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -168,7 +168,7 @@ export const performReload = async ( | |||
| } | |||
| }); | |||
| //@ts-ignore | |||
| __webpack_require__.federation.instance.moduleCache.clear(); | |||
| __webpack_require__?.federation?.instance?.moduleCache?.clear(); | |||
There was a problem hiding this comment.
NOTE to reviewers: The code above this already clears the module cache of all the registered remotes. This line assumes that the current execution context is within a federated remote built using federation + webpack, which might not be the case
MadaraUchiha-314
changed the title
|
@ScriptedAlchemy @2heal1 Is there a way to get a canary version from this PR for testing ? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Types of changes
Checklist