Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed shareStrategy property to optional in ModuleFederationOptions #130

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: changed shareStrategy property to optional in ModuleFederationOptions #130

merged 1 commit into from
Oct 3, 2024

Conversation

jrparish
Copy link
Contributor

@jrparish jrparish commented Oct 3, 2024 •
edited
Loading

shareStrategy was implemented as optional but was required in the typing.

Ref: #105 (comment)

@jrparish jrparish mentioned this pull request Oct 3, 2024
Merged
gioboa
gioboa approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrparish

@gioboa gioboa merged commit 6360a21 into module-federation:main Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrparish @gioboa