Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dynamic remote to example #148

Merged

Conversation

judithhartmann
Copy link
Contributor

Closes #146

I also improved the standalone rendering for the remotes in the example to easier work on them in isolation

@judithhartmann
Copy link
Contributor Author

@gioboa i seem to encounter a problem where the pnpm multiexample only executes 4 scripts at the same time, we have 5 projects in this example now (the tests work if i start all the remotes manually).

is there a way to circumvent this pnpm limit?

@judithhartmann
Copy link
Contributor Author

ok i found the --parallel flag that seems to disregard all limits

@gioboa
Copy link
Collaborator

gioboa commented Oct 6, 2024

Nice, I didn't know about the 4 script limit. I'm glad you found a solution

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@judithhartmann you rock 👏
Thanks for this amazing contribution

@gioboa gioboa merged commit 3815b43 into module-federation:main Oct 6, 2024
4 checks passed
@judithhartmann judithhartmann deleted the doc/dynamic-remote-example branch October 6, 2024 21:31
@jofmi
Copy link

jofmi commented Oct 7, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples for Dynamic Remotes
3 participants