New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trigger description to telegram alerts #1075

Merged

AleksandrMatsko merged 22 commits into moira-alert:master from AleksandrMatsko:feat/trigger-desc-to-tg-alerts

Sep 5, 2024

Member

AleksandrMatsko commented Aug 27, 2024 •

edited

Loading

Add formatted description to telegram sender

Description is formatted with html.

Sender will try to include trigger description to telegram alert. But if one of this conditions is satisfied it can be replaced with other text:

if characters count of message is greater than telegram limits and/or total characters count (with html tags) is greater than telegram limits, then the description will be replaced with: Description is too long for telegram sender.
if first attemt of sending alert failed because of message formatting reasons, then the description will be replaced with: Bad trigger description for telegram sender. Please check trigger.

Closes #353

AleksandrMatsko added 10 commits

August 22, 2024 18:55


          feat: description formatter for tg sender

326213f


          feat: description cutter

c40c1b0


          refactor: separate formatter for telegram

21554bd


          test: start writing for telegram formatter

e26345e


          test: fix failed

321861d


          test: for telegram message formatter

40e83f0


          feat: retry to send telegram alert if error was in message formatting

6f81725


          docs: add comments and godocs

5cca912


          merge master into feat/trigger-desc-to-tg-alerts

cacf9d2


          refactor: exclude <br> tags, change messages for too long description…

a3ffdf7

… and bad message format

AleksandrMatsko marked this pull request as ready for review

August 27, 2024 08:51

AleksandrMatsko requested a review from a team as a code owner

August 27, 2024 08:51

almostinf reviewed

View reviewed changes

senders/telegram/message_formatter.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

senders/telegram/message_formatter.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

senders/telegram/message_formatter.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

senders/telegram/message_formatter.go Show resolved Hide resolved

almostinf reviewed

View reviewed changes

senders/telegram/send.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

senders/telegram/send.go Show resolved Hide resolved

AleksandrMatsko added 4 commits

August 29, 2024 11:54


          refactor: calculating len of string in runes

69d1c63


          refactor: retry sending logic

3e729ce


          refactor: calculating len string in runes in highlighter

9b67b67


          refactor: conditions

d5cc25e

AleksandrMatsko requested a review from almostinf

August 29, 2024 10:07

almostinf reviewed

View reviewed changes

senders/telegram/message_formatter.go Outdated Show resolved Hide resolved


          refactor: working with empty description in tg message formatter

f730da9

almostinf previously approved these changes

View reviewed changes


          refactor: conditions in tg description formatter

766a194

AleksandrMatsko dismissed almostinf’s stale review via

766a194

August 30, 2024 10:01

almostinf previously approved these changes

View reviewed changes

Member Author

AleksandrMatsko commented Aug 30, 2024

/build


          merge origin/master into feat/trigger-desc-to-tg-alerts

a663fe8

Tetrergeru reviewed

View reviewed changes

senders/mattermost/sender.go Outdated Show resolved Hide resolved

AleksandrMatsko added 2 commits

September 3, 2024 16:10


          refactor: cutting for slack sender

65d95a8


          refactor: cutting for mattermost sender

1d118b0

AleksandrMatsko dismissed almostinf’s stale review via

1d118b0

September 3, 2024 09:37

Tetrergeru reviewed

View reviewed changes

senders/msgformat/highlighter_test.go Outdated Show resolved Hide resolved

Tetrergeru reviewed

View reviewed changes

senders/slack/slack.go Outdated Show resolved Hide resolved

Tetrergeru reviewed

View reviewed changes

senders/telegram/message_formatter.go Show resolved Hide resolved

Tetrergeru reviewed

View reviewed changes

senders/telegram/send.go Outdated Show resolved Hide resolved

AleksandrMatsko added 3 commits

September 3, 2024 17:48


          style: rename var

706dc38


          refactor: add default description cutter

7a6a3ec


          style: add comments

46a6c15

AleksandrMatsko requested review from Tetrergeru and almostinf

September 3, 2024 11:52

almostinf approved these changes

View reviewed changes

Tetrergeru approved these changes

View reviewed changes

AleksandrMatsko merged commit a8c5b00 into moira-alert:master

5 checks passed

github-actions bot commented Sep 5, 2024

Build and push Docker images with tag: 2024-09-05.a8c5b00

AleksandrMatsko mentioned this pull request

Add description to message in telegram sender (moira-alert#353) #494

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet