Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add emergency contacts api #1078

Closed
wants to merge 10 commits into from

Conversation

almostinf
Copy link
Member

@almostinf almostinf commented Sep 3, 2024

Add emergency contacts API

Added API for working with emergency contacts - these are the contacts to which notifications will go to users in case of emergency types of problems in Moira

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 64.97462% with 138 lines in your changes missing coverage. Please review.

Project coverage is 52.41%. Comparing base (0197720) to head (a2a1456).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
mock/moira-alert/database.go 0.00% 52 Missing ⚠️
database/redis/emergency_contact.go 76.34% 11 Missing and 11 partials ⚠️
api/handler/emergency_contact.go 69.49% 12 Missing and 6 partials ⚠️
api/handler/team_emergency_contact.go 13.33% 13 Missing ⚠️
api/dto/emergency_contact.go 41.17% 10 Missing ⚠️
database/redis/reply/emergency_contact.go 79.06% 5 Missing and 4 partials ⚠️
database/redis/contact.go 82.05% 6 Missing and 1 partial ⚠️
database/redis/reply/contact.go 0.00% 3 Missing ⚠️
api/controller/emergency_contact.go 95.74% 1 Missing and 1 partial ⚠️
api/dto/contact.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1078       +/-   ##
===========================================
- Coverage   66.85%   52.41%   -14.45%     
===========================================
  Files         219      291       +72     
  Lines       12778    16742     +3964     
===========================================
+ Hits         8543     8775      +232     
- Misses       3684     7395     +3711     
- Partials      551      572       +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almostinf almostinf marked this pull request as ready for review September 5, 2024 12:19
@almostinf almostinf requested a review from a team as a code owner September 5, 2024 12:19
Copy link
Member

@AleksandrMatsko AleksandrMatsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надушнил немного. Глобальных кодовых проблем не вижу

api/dto/emergency_contact.go Show resolved Hide resolved
api/dto/emergency_contact.go Show resolved Hide resolved
api/dto/emergency_contact.go Show resolved Hide resolved
api/handler/emergency_contact.go Show resolved Hide resolved
api/controller/emergency_contact.go Show resolved Hide resolved
}, nil
}

// UpdateEmergencyContact a method to delete the emergency contact.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очепятка

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил

@almostinf almostinf closed this Sep 10, 2024
@almostinf almostinf deleted the feat/add-emergency-contacts-api branch September 10, 2024 10:17
@almostinf almostinf restored the feat/add-emergency-contacts-api branch September 10, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants