-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add emergency contacts api #1078
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1078 +/- ##
===========================================
- Coverage 66.85% 52.41% -14.45%
===========================================
Files 219 291 +72
Lines 12778 16742 +3964
===========================================
+ Hits 8543 8775 +232
- Misses 3684 7395 +3711
- Partials 551 572 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Надушнил немного. Глобальных кодовых проблем не вижу
api/controller/emergency_contact.go
Outdated
}, nil | ||
} | ||
|
||
// UpdateEmergencyContact a method to delete the emergency contact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Очепятка
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Исправил
Add emergency contacts API
Added API for working with emergency contacts - these are the contacts to which notifications will go to users in case of emergency types of problems in Moira