Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): remove memory leak in api #898

Closed
wants to merge 16 commits into from

Conversation

almostinf
Copy link
Member

Remove memory leak in api

These changes should definitely fix the memory leak associated with trigger index benchmarks, but are non-guaranteed to fix the entire issue

@almostinf almostinf requested a review from a team as a code owner August 21, 2023 13:00
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #898 (6ef1a33) into master (31167c6) will decrease coverage by 0.12%.
Report is 6 commits behind head on master.
The diff coverage is 52.56%.

❗ Current head 6ef1a33 differs from pull request most recent head dc1728f. Consider uploading reports for the commit dc1728f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
- Coverage   69.63%   69.51%   -0.12%     
==========================================
  Files         191      191              
  Lines       10564    10622      +58     
==========================================
+ Hits         7356     7384      +28     
- Misses       2782     2808      +26     
- Partials      426      430       +4     
Files Changed Coverage Δ
api/dto/event_history_item.go 0.00% <ø> (ø)
api/dto/events.go 0.00% <ø> (ø)
api/dto/notification.go 0.00% <ø> (ø)
api/dto/triggers.go 61.61% <ø> (ø)
api/handler/handler.go 0.00% <0.00%> (ø)
api/middleware/logger.go 0.00% <0.00%> (ø)
cmd/api/main.go 0.00% <0.00%> (ø)
datatypes.go 85.15% <ø> (ø)
index/batch.go 87.83% <33.33%> (ø)
index/actualizer.go 70.76% <42.85%> (+0.45%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -102,6 +103,21 @@ func NewHandler(db moira.Database, log moira.Logger, index moira.Searcher, confi
router.Get("/swagger/*", httpSwagger.Handler(
httpSwagger.URL("/api/swagger/doc.json"),
))
router.Route("/debug/pprof", func(router chi.Router) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ого

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

понял, спасибо

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

никогда не замечал

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я уже успел написал скрипт, который нагрузку генерирует и похоже зря :(

@almostinf
Copy link
Member Author

/build

@github-actions
Copy link

Build and push Docker images with tag: fix-remove-memory-leak-in-api.2023-08-30.ce955b6

@almostinf almostinf marked this pull request as draft October 4, 2023 19:24
@almostinf almostinf closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants