Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metric in notifier-selfcheck #910

Merged
merged 8 commits into from
Sep 14, 2023

Conversation

kissken
Copy link
Member

@kissken kissken commented Sep 11, 2023

No description provided.

@kissken
Copy link
Member Author

kissken commented Sep 11, 2023

/build

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Merging #910 (1d4fd48) into master (9d54d2f) will decrease coverage by 0.05%.
Report is 3 commits behind head on master.
The diff coverage is 61.73%.

❗ Current head 1d4fd48 differs from pull request most recent head 57cf106. Consider uploading reports for the commit 57cf106 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
- Coverage   68.93%   68.89%   -0.05%     
==========================================
  Files         195      196       +1     
  Lines       10866    10948      +82     
==========================================
+ Hits         7491     7543      +52     
- Misses       2934     2962      +28     
- Partials      441      443       +2     
Files Changed Coverage Δ
cmd/api/main.go 0.00% <0.00%> (ø)
database/redis/trigger.go 72.46% <0.00%> (-6.28%) ⬇️
metric_source/prometheus/prometheus.go 46.66% <ø> (ø)
notifier/notifications/notifications.go 64.91% <0.00%> (ø)
notifier/selfstate/config.go 100.00% <ø> (ø)
cmd/api/trigger_stats.go 35.71% <35.71%> (ø)
cmd/api/config.go 97.50% <100.00%> (+0.20%) ⬆️
database/redis/contact.go 90.82% <100.00%> (-0.09%) ⬇️
helpers.go 89.74% <100.00%> (ø)
metric_source/prometheus/fetch.go 72.50% <100.00%> (+72.50%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

metrics/heartbeat.go Outdated Show resolved Hide resolved
@kissken kissken marked this pull request as ready for review September 14, 2023 07:22
@kissken kissken requested a review from a team as a code owner September 14, 2023 07:22
@kissken kissken merged commit 8e3367e into master Sep 14, 2023
6 checks passed
@kissken kissken deleted the feature/add_metric_to_notifier_selfcheck branch September 14, 2023 08:29
@github-actions
Copy link

Build and push Docker images with tag: 2023-09-14.8e3367e

1 similar comment
@github-actions
Copy link

Build and push Docker images with tag: 2023-09-14.8e3367e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants