Skip to content

Commit

Permalink
chore: moving f32 score field to reserved (#257)
Browse files Browse the repository at this point in the history
  • Loading branch information
anp13 authored Jan 23, 2024
1 parent d6a129a commit b7ae288
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions proto/leaderboard.proto
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,19 @@ message _Element {
uint32 id = 1;

// The value by which this element is sorted within the leaderboard.
float score_f32 = 2 [deprecated = true];

double score = 3;

reserved 2;
}

// Query APIs returning RankedElement offer the familiar Element id and score tuple, but they
// also include the rank per the individual API's ranking semantic.
message _RankedElement {
uint32 id = 1;
float score_f32 = 2 [deprecated = true];
uint32 rank = 3;
double score = 4;

reserved 2;
}

// Query APIs using RankRange expect a limit of 8192 elements. Requesting a range wider than
Expand Down Expand Up @@ -107,18 +108,18 @@ message _Unbounded { }
message _ScoreRange {
oneof min {
_Unbounded unbounded_min = 1;
// IEEE 754 single precision 32 bit floating point number.
// IEEE 754 single precision 64 bit floating point number.
// Momento does not support NaN or Inf in leaderboards.
float min_inclusive_f32 = 2 [deprecated = true];
double min_inclusive = 5;
}
oneof max {
_Unbounded unbounded_max = 3;
// IEEE 754 single precision 32 bit floating point number.
// IEEE 754 single precision 64 bit floating point number.
// Momento does not support NaN or Inf in leaderboards.
float max_exclusive_f32 = 4 [deprecated = true];
double max_exclusive = 6;
}

reserved 2, 4;
}

enum _Order {
Expand Down

0 comments on commit b7ae288

Please sign in to comment.