fix: Remove self-generated google common protos #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop generating google common protos. A customer is getting conflicts because they are colliding with those in the proto-google-common-protos dependency. Temporarily disable conditional releases of the java protos and add debug statements because java appears to never be released.
|
I was able to run the integration tests in the Java SDK using this as a local dependency. I'll do more testing once it's released. |
nand4011
commented
Aug 4, 2023
| protobuf(files("../proto/")) | ||
| protobuf(files(fileTree("../proto") { | ||
| include("*.proto") | ||
| exclude("**/*/*.proto") |
There was a problem hiding this comment.
This is the meat of the change. The top level proto files are ours. There is a google directory containing the protos we want to exclude.
cprice404
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop generating google common protos. A customer is getting conflicts because they are colliding with those in the proto-google-common-protos dependency.
Change java artifact developer to the generic momento dev to match the java SDK.
Temporarily disable conditional releases of the java protos and add debug statements because java appears to never be released.