chore: add missing export for vectorindex namespace in grpc-web #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprice404
force-pushed
the
add-missing-vector-things-for-web-sdk
branch
from
d231b19
to
bf9acb9
Compare
proto/auth.proto
Outdated
| @@ -6,7 +6,7 @@ option go_package = "github.com/momentohq/client-sdk-go;client_sdk_go"; | |||
| option java_multiple_files = true; | |||
| option java_package = "momento.auth"; | |||
|
|
|||
| package auth; | |||
| //package auth; | |||
There was a problem hiding this comment.
Why did we comment out all the package names? JC want to double check meant to leave that in?
malandis
reviewed
Sep 5, 2023
pgautier404
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.