fix: edit python generated pb2 import statements in general #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous version of `python/run-protoc.sh`, we selectively edited import statements for `extensions_pb2`. With the prior addition of `permissionmessages`, the package is broken. We need to edit those as well. In order to avoid this in the present and future, we generalize the edits to all pb2 import statements in our generated code.
nand4011
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version of
python/run-protoc.sh, we selectivelyedited import statements for
extensions_pb2. With the prior additionof
permissionmessages, the package is broken. We need to edit thoseas well.
In order to avoid this in the present and future, we generalize the
edits to all pb2 import statements in our generated code.