Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add protos for SetIf #267

Merged
merged 4 commits into from
Feb 29, 2024
Merged

feat: add protos for SetIf #267

merged 4 commits into from
Feb 29, 2024

Conversation

honeyAcorn
Copy link
Contributor

No description provided.

@honeyAcorn honeyAcorn marked this pull request as ready for review February 26, 2024 18:03
tylerburdsall
tylerburdsall previously approved these changes Feb 26, 2024
View reviewed changes
cprice404
cprice404 previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. not sure what's up with the CI, if that needs to be resolved before merging, but the proto changes look good

@honeyAcorn
Copy link
Contributor Author

Thanks for adding the rust and csharp include.

@pgautier404 pgautier404 merged commit d9e6241 into main Feb 29, 2024
7 checks passed
@pgautier404 pgautier404 deleted the set_if branch February 29, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cprice404 cprice404 cprice404 approved these changes

@tylerburdsall tylerburdsall tylerburdsall left review comments

@malandis malandis Awaiting requested review from malandis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@honeyAcorn @cprice404 @tylerburdsall @pgautier404