feat: add trailers proto #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malandis
reviewed
Aug 1, 2024
malandis
previously approved these changes
Aug 1, 2024
cprice404
reviewed
Aug 1, 2024
ben-kugler
force-pushed
the
add-trailers-proto
branch
from
a8c9ec6
to
6a6c3cf
Compare
malandis
reviewed
Aug 10, 2024
| // { | ||
| // Key: "err" | ||
| // Values: [ | ||
| // "momento_general_err", |
There was a problem hiding this comment.
Could you add back in the clarifying comments for each of the alternatives we had previously? (as in 6a6c3cf).
|
this wfm if it works for @malandis , @kvcache , and @virratanasangpunth |
cprice404
approved these changes
Aug 12, 2024
malandis
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.