feat: add invite member apis #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishtigupta
force-pushed
the
feat/invite-member-apis
branch
from
1da9f32
to
9fa97e4
Compare
rishtigupta
force-pushed
the
feat/invite-member-apis
branch
from
9fa97e4
to
5783bb6
Compare
PDXKimani
approved these changes
Sep 24, 2024
cprice404
approved these changes
Sep 24, 2024
| @@ -15,6 +15,11 @@ service GlobalAdmin { | |||
| rpc ListMembers(_ListMembersRequest) returns(_ListMembersResponse) {} | |||
| rpc GetEndpointsForAccount(_GetEndpointsForAccountRequest) returns (_GetEndpointsForAccountResponse) {} | |||
| rpc SetAccountName(_SetAccountNameRequest) returns (_SetAccountNameResponse) {} | |||
| rpc InviteMember(_InviteMemberRequest) returns (_InviteMemberResponse) {} | |||
| rpc AcceptInvitation(_AcceptInvitationRequest) returns (_AcceptInvitationResponse) {} | |||
| rpc RejectInvitation(_RejectInvitationRequest) returns (_RejectInvitationResponse) {} | |||
There was a problem hiding this comment.
@PDXKimani FWIW I think in the console UI we should use the word "Decline" for this. I don't have any concerns about the proto not matching the console UI if you've already shipped but just calling it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.