feat: add timeout to individual requests in batch call #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratik151192
force-pushed
the
add-timeout-batch
branch
from
56c7bbd
to
ff41794
Compare
eaddingtonwhite
previously approved these changes
Aug 31, 2023
pratik151192
dismissed
eaddingtonwhite’s stale review
The base branch was changed.
pratik151192
force-pushed
the
add-timeout-batch
branch
from
ff41794
to
14b0713
Compare
|
@eaddingtonwhite just stupid git rebase stuff |
eaddingtonwhite
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
request_timeoutfor each individualset,get, ordeletecalls we make within the batch operations. This is just a hardening mechanism such that one if of the go-routines doesn't hang indefinitely and blocks the entire operation.