feat: Add a load generator to the examples #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nand4011
commented
Jul 24, 2023
| @@ -19,9 +19,14 @@ repositories { | |||
| dependencies { | |||
| implementation("software.momento.java:sdk:1.0.0") | |||
|
|
|||
| implementation("com.google.guava:guava:31.1-android") | |||
There was a problem hiding this comment.
This is the version of guava transitively pulled in by our protos.
Add a load generator example in the style of load generators we've made for other SDKs. It schedules a configurable number of alternating write and read tasks, limiting the total tps using a Guava RateLimiter.
| } else if (response instanceof GetResponse.Error error) { | ||
| handleErrorResponse(error.getErrorCode()); | ||
| } | ||
| scheduleSet(workerId, nextOperationNum); |
There was a problem hiding this comment.
This looks like unintended else we'll be in an infinite loop of set-get-set?
There was a problem hiding this comment.
That is intended. It schedules alternating write and read tasks that reschedule themselves forever. The throughput is controlled by the rate limiter blocking when the tasks run too quickly. It is broken by the shutdown method that the main method calls at the end of the benchmark.
times that occur when starting. Switch time measurement to nanoTime because millis didn't give enough resolution.
pratik151192
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a load generator example in the style of load generators we've made for other SDKs. It schedules a configurable number of alternating write and read tasks, limiting the total tps using a Guava RateLimiter.