Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add topic example #341

Merged
merged 2 commits into from
Dec 14, 2023
Merged

feat: add topic example #341

merged 2 commits into from
Dec 14, 2023

Conversation

rishtigupta
Copy link
Contributor

PR Description:

  • add topic example
  • remove closing of grpc connection in the subscription wrapper class

cprice404
cprice404 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@rishtigupta rishtigupta marked this pull request as ready for review December 14, 2023 19:41
@rishtigupta rishtigupta merged commit 4460c67 into main Dec 14, 2023
5 checks passed
@rishtigupta rishtigupta deleted the feat/topics-follow-ups branch December 14, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cprice404 cprice404 cprice404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishtigupta @cprice404