feat: add grpc config options and turn off keepalive for Lambda config #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anitarua
commented
Mar 6, 2024
Comment on lines
-42
to
-44
| channelBuilder.keepAliveTime(10, TimeUnit.SECONDS); | ||
| channelBuilder.keepAliveTimeout(5, TimeUnit.SECONDS); | ||
| channelBuilder.keepAliveWithoutCalls(true); |
There was a problem hiding this comment.
propagated these values to the prebuilt topics configs
anitarua
commented
Mar 6, 2024
momento-sdk/src/main/java/momento/sdk/internal/GrpcChannelOptions.java
Outdated
Show resolved
Hide resolved
cprice404
reviewed
Mar 6, 2024
There was a problem hiding this comment.
looking good, some minor comments, and would also like to get @pratik151192 or someone to review before we merge.
momento-sdk/src/main/java/momento/sdk/internal/GrpcChannelOptions.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/main/java/momento/sdk/ScsControlGrpcStubsManager.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/main/java/momento/sdk/config/transport/GrpcConfiguration.java
Outdated
Show resolved
Hide resolved
cprice404
reviewed
Mar 7, 2024
momento-sdk/src/main/java/momento/sdk/config/transport/GrpcConfiguration.java
Outdated
Show resolved
Hide resolved
cprice404
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
lgtm. let's get either @pratik151192 or @nand4011 to review, just to make sure we're all aligned on the new API surface area, then 🚢
nand4011
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds message size to support messages up to 5mb by default (though I was only able to find the max receive message size option through the NettyChannelBuilder interface).
Adds keepalive settings to the configs as well. Disables keepalive for the cache control client and the Lambda prebuilt config. Sets different keepalive values for the topics prebuilt configs based on the values that were hardcoded into the topic grpc manager.