chore: add cancelled errors to load-gen #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nand4011
reviewed
Mar 14, 2024
| @@ -244,7 +251,7 @@ public static void main(String[] args) throws InterruptedException { | |||
| // may increase. | |||
| // Note: You are likely to see degraded performance if you increase this above 50 | |||
| // and observe elevated client-side latencies. | |||
| final int numberOfConcurrentRequests = 50; | |||
| final int numberOfConcurrentRequests = 10; | |||
There was a problem hiding this comment.
Did you intend to change this?
There was a problem hiding this comment.
yeah because max TPS was 50 :) so 1:1 here isn't needed and also is a bit misleading/confusing
nand4011
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have edited load-gens a couple times locally for cancelled might as well commit it