Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use server metadata for item not found #369

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

malandis
Copy link
Contributor

@malandis malandis commented Jun 24, 2024

Consumes the server metadata change from element_not_found to item_not_found.

Since the server now sends metadata for these various error causes, we
update the client to read them.
The fix for store not found will come later.
@malandis malandis changed the title fix: use server metadata for store not found and item not found fix: use server metadata for item not found Jun 24, 2024
@malandis malandis requested review from pgautier404, bruuuuuuuce and a team June 24, 2024 22:34
Copy link
Contributor

@bruuuuuuuce bruuuuuuuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@malandis malandis merged commit a6b9f09 into main Jun 24, 2024
5 checks passed
@malandis malandis deleted the fix/cut-over-to-metadata-for-not-found branch June 24, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants