refactor: storage tests should use a single test store and base #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the storage tests to use a base class similar to the one just introduced for cache. Handles store set up and tear down uniformly.
malandis
commented
Jul 9, 2024
| @@ -49,7 +49,7 @@ public PreviewStorageClientBuilder withConfiguration( | |||
| * | |||
| * @return the client. | |||
| */ | |||
| public IPreviewStorageClient build() { | |||
| public PreviewStorageClient build() { | |||
There was a problem hiding this comment.
I changed this since PreviewStorageClient is Closeable. In order to both use the builder and explicitly call close on the client, we should return the concrete class.
nand4011
reviewed
Jul 9, 2024
nand4011
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the storage tests to use a base class similar to the one
just introduced for cache. Handles store set up and tear down uniformly.