fix: storage SDK orElseThrow should take a supplier #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `orElseThrow` signature of Java Optionals requires a single arg, `supplier`, that is a lambda function returning the exception that the user wishes to have thrown if the optional is empty. In our current storage client code we have an empty-args signature, which would be surprising to Java users familiar with Optionals. This commit updates the signature to accept a supplier.
malandis
approved these changes
Jul 10, 2024
| @@ -64,16 +65,20 @@ public static <T> MomentoOptional<T> empty(String onEmptyExceptionMessage) { | |||
| * @return the value. | |||
| */ | |||
| public T get() { | |||
| return this.orElseThrow(); | |||
| return optional.orElseThrow(() -> new ClientSdkException(onEmptyExceptionMessage)); | |||
| return optional.orElseThrow(() -> new ClientSdkException(onEmptyExceptionMessage)); | ||
| public <X extends Throwable> T orElseThrow(Supplier<? extends X> exceptionSupplier) throws X { | ||
| if (this.isEmpty()) { | ||
| throw exceptionSupplier.get(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
orElseThrowsignature of Java Optionals requires a singlearg,
supplier, that is a lambda function returning the exceptionthat the user wishes to have thrown if the optional is empty.
In our current storage client code we have an empty-args signature,
which would be surprising to Java users familiar with Optionals.
This commit updates the signature to accept a supplier.