fix: fix failing storage tests #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop looking at error metadata to determine whether an already exists error is for a store or cache. We can check it when that is added on the server side. Update a test that was checking that the server could support empty keys in the store client. That changed on the server side.
nand4011
force-pushed
the
fix-store-failures
branch
from
e72ab97
to
0460f93
Compare
|
The build examples step can't go green because the released version uses the code no longer works. |
malandis
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop looking at error metadata to determine whether an already exists error is for a store or cache. We can check it when that is added on the server side.
Update a test that was checking that the server could support empty keys in the store client. That changed on the server side.