Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add byte array for list methods on the list name #392

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feat: add byte array for list methods on the list name #392

merged 1 commit into from
Sep 4, 2024

Conversation

malandis
Copy link
Contributor

@malandis malandis commented Sep 4, 2024

Adds various overloads for cache listFetch,
listConcatenateFrontByteArray, and listRetain for the listName
as a byte array.

@malandis
feat: add byte array for list methods on the list name
b72e767 
Adds various overloads for cache `listFetch`,
`listConcatenateFrontByteArray`, and `listRetain` for the `listName`
as a byte array.
@malandis malandis requested review from nand4011 and a team September 4, 2024 00:23
@rishtigupta
Copy link
Contributor

lgtm!
Do we want a case where we have byte[] listname and string[] values for apis like listConcatenate ?

rishtigupta
rishtigupta approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@rishtigupta rishtigupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@malandis malandis merged commit 41ba4b5 into main Sep 4, 2024
5 checks passed
@malandis malandis deleted the feat/list-byte-array-overloads branch September 4, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishtigupta rishtigupta rishtigupta approved these changes

@nand4011 nand4011 Awaiting requested review from nand4011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malandis @rishtigupta