Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve resource exhausted error message #399

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Nov 1, 2024

Closes https://github.com/momentohq/dev-eco-issue-tracker/issues/1052

Adds a factory method for LimitExceededException that takes in an error cause (err metadata or grpc error details string) and constructs a LimitExceededException with a message wrapper that includes the limit that was exceeded.

@anitarua anitarua marked this pull request as ready for review November 1, 2024 20:42
@anitarua anitarua requested a review from a team November 1, 2024 20:42
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice how this one is compact! Just one suggestion re: the new enum.

@anitarua anitarua requested review from a team and malandis November 8, 2024 17:32
@anitarua anitarua merged commit 076ad5d into main Nov 8, 2024
5 checks passed
@anitarua anitarua deleted the resource-exhausted branch November 8, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants