fix: empty string doesn't work for CredentialProvider.fromString test

momentohq · Jan 17, 2024 · 5e6ab76 · 5e6ab76
1 parent 56757ac
commit 5e6ab76
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/client-sdk-nodejs/test/integration/client-constructor-default-configs.test.ts b/packages/client-sdk-nodejs/test/integration/client-constructor-default-configs.test.ts
@@ -7,6 +7,10 @@ import {
 } from '../../src';
 import {credsProvider} from './integration-setup';
 
+// These tokens have valid syntax, but they don't actually have valid credentials.  Just used for unit testing.
+const fakeTestV1ApiKey =
+  'eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJPbmxpbmUgSldUIEJ1aWxkZXIiLCJpYXQiOjE2NzgzMDU4MTIsImV4cCI6NDg2NTUxNTQxMiwiYXVkIjoiIiwic3ViIjoianJvY2tldEBleGFtcGxlLmNvbSJ9.8Iy8q84Lsr-D3YCo_HP4d-xjHdT8UCIuvAYcxhFMyz8';
+
 describe('default configurations', () => {
   it('CacheClient should be able to be constructed with a default configuration', async () => {
     const cacheClientViaConstructor = new CacheClient({
@@ -41,7 +45,7 @@ describe('default configurations', () => {
 
   it('CacheClient should be able to be constructed with a simple string for fromString', () => {
     const cacheClientViaConstructor = new CacheClient({
-      credentialProvider: CredentialProvider.fromString(''),
+      credentialProvider: CredentialProvider.fromString(fakeTestV1ApiKey),
       defaultTtlSeconds: 60,
     });
     expect(cacheClientViaConstructor).toBeInstanceOf(CacheClient);

diff --git a/packages/client-sdk-web/test/integration/client-constructor-default-configs.test.ts b/packages/client-sdk-web/test/integration/client-constructor-default-configs.test.ts
@@ -7,6 +7,10 @@ import {
 } from '../../src';
 import {credsProvider} from './integration-setup';
 
+// These tokens have valid syntax, but they don't actually have valid credentials.  Just used for unit testing.
+const fakeTestV1ApiKey =
+  'eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJPbmxpbmUgSldUIEJ1aWxkZXIiLCJpYXQiOjE2NzgzMDU4MTIsImV4cCI6NDg2NTUxNTQxMiwiYXVkIjoiIiwic3ViIjoianJvY2tldEBleGFtcGxlLmNvbSJ9.8Iy8q84Lsr-D3YCo_HP4d-xjHdT8UCIuvAYcxhFMyz8';
+
 describe('default configurations', () => {
   it('CacheClient should be able to be constructed with a default configuration', () => {
     const cacheClientViaConstructor = new CacheClient({
@@ -35,7 +39,7 @@ describe('default configurations', () => {
 
   it('CacheClient should be able to be constructed with a simple string for fromString', () => {
     const cacheClientViaConstructor = new CacheClient({
-      credentialProvider: CredentialProvider.fromString(''),
+      credentialProvider: CredentialProvider.fromString(fakeTestV1ApiKey),
       defaultTtlSeconds: 60,
     });
     expect(cacheClientViaConstructor).toBeInstanceOf(CacheClient);