Skip to content

Commit

Permalink
revert renamings
Browse files Browse the repository at this point in the history
  • Loading branch information
anitarua committed Aug 22, 2024
1 parent 1398ef4 commit 89132a8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ export interface StorageConfiguration {

/**
* Convenience copy constructor that updates the client-side timeout setting in the TransportStrategy
* @param {number} requestTimeoutMillis
* @param {number} clientTimeoutMillis
* @returns {StorageConfiguration} a new Configuration object with its TransportStrategy updated to use the specified client timeout
*/
withRequestTimeoutMillis(requestTimeoutMillis: number): StorageConfiguration;
withClientTimeoutMillis(clientTimeoutMillis: number): StorageConfiguration;

/**
* Copy constructor for overriding TransportStrategy
Expand Down Expand Up @@ -85,11 +85,11 @@ export class StorageClientConfiguration implements StorageConfiguration {
return this.retryStrategy;
}

withRequestTimeoutMillis(requestTimeoutMillis: number): StorageConfiguration {
withClientTimeoutMillis(clientTimeoutMillis: number): StorageConfiguration {
return new StorageClientConfiguration({
loggerFactory: this.loggerFactory,
transportStrategy:
this.transportStrategy.withRequestTimeoutMillis(requestTimeoutMillis),
this.transportStrategy.withClientTimeoutMillis(clientTimeoutMillis),
retryStrategy: this.retryStrategy,
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ export interface StorageTransportStrategy {

/**
* Copy constructor to update the client-side timeout
* @param {number} requestTimeoutMillis
* @param {number} clientTimeoutMillis
* @returns {StorageTransportStrategy} a new StorageTransportStrategy with the specified client timeout
*/
withRequestTimeoutMillis(
requestTimeoutMillis: number
withClientTimeoutMillis(
clientTimeoutMillis: number
): StorageTransportStrategy;
}

Expand Down Expand Up @@ -78,12 +78,12 @@ export class StaticStorageTransportStrategy
});
}

withRequestTimeoutMillis(
requestTimeoutMillis: number
withClientTimeoutMillis(
clientTimeoutMillis: number
): StorageTransportStrategy {
return new StaticStorageTransportStrategy({
grpcConfiguration:
this.grpcConfig.withDeadlineMillis(requestTimeoutMillis),
this.grpcConfig.withDeadlineMillis(clientTimeoutMillis),
});
}
}

0 comments on commit 89132a8

Please sign in to comment.