feat: add sequence number to TopicItem and add optional onDiscontinuity callback #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anitarua
changed the title
cprice404
reviewed
Aug 23, 2024
| @@ -238,16 +239,24 @@ export class PubsubClient extends AbstractPubsubClient<ServiceError> { | |||
| options.subscription | |||
| ); | |||
| } | |||
| } else if (resp?.heartbeat) { | |||
| } else if (resp.heartbeat) { | |||
There was a problem hiding this comment.
this is interesting, why did this change? Just shouldn't have had the ? in the first place?
There was a problem hiding this comment.
Yeah, I inspected the type (_SubscriptionItem) when I saw that and I think resp will never be undefined; just that it may not contain any data if something goes wrong, and that would be handled by the else case.
constructor(data?: any[] | ({} & (({
item?: _TopicItem;
discontinuity?: never;
heartbeat?: never;
} | {
item?: never;
discontinuity?: _Discontinuity;
heartbeat?: never;
} | {
item?: never;
discontinuity?: never;
heartbeat?: _Heartbeat;
}))));
packages/core/src/internal/clients/pubsub/AbstractPubsubClient.ts
Outdated
Show resolved
Hide resolved
packages/core/src/internal/clients/pubsub/AbstractPubsubClient.ts
Outdated
Show resolved
Hide resolved
|
|
||
| constructor(_value: string | Uint8Array, options?: TopicItemOptions) { | ||
| constructor( |
There was a problem hiding this comment.
This is technically a breaking change to this constructor but I don't expect anyone external to be constructing these, so I think what you've done here is probably the best way to go.
cprice404
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards https://github.com/momentohq/dev-eco-issue-tracker/issues/973
Tested new onDiscontinuity callback locally using a stubbed topics service that returns only discontinuities.