Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add NotSet path for increase/decrease ttl apis #1447

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: add NotSet path for increase/decrease ttl apis #1447

merged 1 commit into from
Oct 16, 2024

Conversation

rishtigupta
Copy link
Contributor

@rishtigupta rishtigupta commented Oct 15, 2024 •
edited
Loading

PR Description:

  • Add the "NotSet" path in increase/decrease ttl apis

Issue

closes #1446

@rishtigupta rishtigupta marked this pull request as ready for review October 15, 2024 21:22
malandis
malandis reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need tests to cover this path

@rishtigupta
Copy link
Contributor Author

We'll also need tests to cover this path

The tests already existed with check for an Error instead of NotSet path. Updated the tests.

@rishtigupta rishtigupta merged commit 8e48b08 into main Oct 16, 2024
13 checks passed
@rishtigupta rishtigupta deleted the fix/ttl-apis branch October 16, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anitarua anitarua anitarua approved these changes

@malandis malandis malandis approved these changes

@nand4011 nand4011 Awaiting requested review from nand4011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NotSet condition to increase/decrease ttl in JS SDK
3 participants
@rishtigupta @malandis @anitarua