fix: update dependencies to resolve dependabot alert #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprice404
approved these changes
Jul 31, 2023
| "@gomomento/sdk": "1.26.2", | ||
| "@grpc/grpc-js": "1.8.14", | ||
| "@gomomento/sdk": "1.28.0", | ||
| "@grpc/grpc-js": "1.8.17", |
There was a problem hiding this comment.
this looks fine but i'm wondering if for the grpc-js one, if we used one of those fuzzy match things like ^1.whatever, if that would make it less likely to hit this in the future. I genuinely don't know; probably not, if the version gets locked in package-lock.json anyway.
not a blocker either way, just food for thought.
There was a problem hiding this comment.
Yeah, since we're shipping package-lock I also don't think that would help here. If this becomes a recurrent issue, we should think about maybe relaxing some of these selectors and removing the lockfiles for the examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the version of the
@grpc/grpc-jsdependency such that its transitive dependency withprotobufjsis bumped to the latest: 7.2.4. Prior versions had a vulnerability which is addressed in this latest version.