feat: add a configuration for lambda #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nand4011
commented
Aug 9, 2023
| static v1( | ||
| loggerFactory: MomentoLoggerFactory = defaultLoggerFactory | ||
| ): CacheConfiguration { | ||
| const deadlineMillis = 1100; |
There was a problem hiding this comment.
I copied the InRegionDefault here. Should we use this timeout or the low latency timeout?
There was a problem hiding this comment.
definitely not LowLatency. If we were going to change it from InRegion.Default I think it would be to increase it, not decrease it, but my gut is to go with the same value we use for InRegion.Default.
@eaddingtonwhite lmk if you have any super strong opinions here.
nand4011
force-pushed
the
lambda-config
branch
2 times, most recently
from
04eb3b5
to
2b1c63a
Compare
cprice404
reviewed
Aug 9, 2023
| static v1( | ||
| loggerFactory: MomentoLoggerFactory = defaultLoggerFactory | ||
| ): CacheConfiguration { | ||
| const deadlineMillis = 1100; |
There was a problem hiding this comment.
definitely not LowLatency. If we were going to change it from InRegion.Default I think it would be to increase it, not decrease it, but my gut is to go with the same value we use for InRegion.Default.
@eaddingtonwhite lmk if you have any super strong opinions here.
packages/client-sdk-nodejs/src/config/transport/grpc-configuration.ts
Outdated
Show resolved
Hide resolved
packages/client-sdk-nodejs/test/unit/config/transport/transport-strategy.test.ts
Outdated
Show resolved
Hide resolved
Make the number of data clients a cache client creates configurable. 6 is likely too many for lambdas as the extra latency for the first 6 calls isn't worth it in a short-lived environment. Create a new configuration, InRegion.Lambda, for use inside lambdas. It only creates 1 data client instead of 6.
nand4011
force-pushed
the
lambda-config
branch
from
2b1c63a
to
ab2c0dd
Compare
cprice404
approved these changes
Aug 11, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the number of data clients a cache client creates configurable. 6 is likely too many for lambdas as the extra latency for the first 6 calls isn't worth it in a short-lived environment.
Create a new configuration, InRegion.Lambda, for use inside lambdas. It only creates 1 data client instead of 6.