Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add batch get, set, delete functions for nodejs #916

Merged
merged 7 commits into from
Sep 19, 2023
Merged

feat: add batch get, set, delete functions for nodejs #916

merged 7 commits into from
Sep 19, 2023

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Sep 14, 2023 •
edited
Loading

Addresses #460 by implementing a BatchUtils namespace that offers the batchGet, batchSet, and batchDelete functions in the Nodejs SDK.

@anitarua anitarua marked this pull request as ready for review September 14, 2023 20:18
@anitarua anitarua requested a review from a team September 14, 2023 20:19
pgautier404
pgautier404 reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@pgautier404 pgautier404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple super picky comments, but I think this looks great!

@pgautier404 pgautier404 requested a review from a team September 14, 2023 22:50
cprice404
cprice404 reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking really good! just a few minor thoughts, mostly API-related

packages/client-sdk-nodejs/src/batchutils/batch-functions.ts Outdated Show resolved Hide resolved
packages/client-sdk-nodejs/src/batchutils/batch-functions.ts Outdated Show resolved Hide resolved
packages/client-sdk-nodejs/src/batchutils/batch-functions.ts Outdated Show resolved Hide resolved
packages/client-sdk-nodejs/src/batchutils/batch-functions.ts Show resolved Hide resolved
packages/client-sdk-nodejs/src/batchutils/batch-props.ts Show resolved Hide resolved
packages/client-sdk-nodejs/src/batchutils/batch-props.ts Outdated Show resolved Hide resolved
packages/client-sdk-nodejs/src/index.ts Outdated Show resolved Hide resolved
packages/client-sdk-nodejs/test/integration/batchutils.test.ts Show resolved Hide resolved
packages/client-sdk-nodejs/test/integration/batchutils.test.ts Show resolved Hide resolved
pratik151192
pratik151192 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@pratik151192 pratik151192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉👏🚀

cprice404
cprice404 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

party

@anitarua anitarua merged commit d7056f3 into main Sep 19, 2023
13 checks passed
@anitarua anitarua deleted the batchutils branch September 19, 2023 00:14
@anitarua anitarua mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruuuuuuuce bruuuuuuuce bruuuuuuuce left review comments

@pgautier404 pgautier404 pgautier404 left review comments

@pratik151192 pratik151192 pratik151192 approved these changes

@cprice404 cprice404 cprice404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anitarua @cprice404 @pgautier404 @pratik151192 @bruuuuuuuce