chore: relax auth test expiration window for CIs under high contention #995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/momentohq/dev-eco-issue-tracker/issues/536
I have been observing failed CIs on this repo since a while and the most common culprits in my observation have been:
x
is withiny-1
andy+1
wherey
is the expiration time returned by the server after the API call. The window here is small even though it does succeed locally in a loop of 1000 runs. I believe the reason it fails on CIs so frequently is either:Instead of testing expirationTime at a second granularity with 1 second error margin, I have changed it to test at minute granularity with 1 minute error margin. This gives some breathing room for the CIs to succeed.