chore: wrap momento metrics json in momento object for cloudwatch metric filters
#998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or cloudwatch metric filters
pratik151192
reviewed
Nov 1, 2023
| * The ID of the specific connection that made the request | ||
| */ | ||
| connectionID: string; | ||
| MomentoMetricsMiddleware: { |
There was a problem hiding this comment.
not a strong opinion but I think momento. numActiveRequestsAtStart or momento.duration will be a cleaner UX than MomentoMetricsMiddleware.duration
There was a problem hiding this comment.
I like that better too, updated
pratik151192
previously approved these changes
Nov 1, 2023
pratik151192
approved these changes
Nov 1, 2023
anitarua
changed the title
momento object for cloudwatch metric filters
|
Thanks for doing this! we might wanna file a ticket to capture that we should make the same update in .NET. |
|
good call, the .NET update seems to be simpler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that #970 can incorporate MomentoMetricsMiddleware into the metric filters (e.g.
{$.MomentoMetricsMiddleware.status >= 0}) to avoid clashing with other metrics customers may stream to a log group.