feat: add support for CreateSigningKey, RevokeSigningKey, and ListSigningKeys APIs #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerburdsall
requested review from
kvcache,
mjindalmotiv8,
virratanasangpunth and
wandaitzuchen
| @@ -70,5 +80,58 @@ async def list_caches(self, next_token: Optional[str] = None) -> ListCachesRespo | |||
| except Exception as e: | |||
| raise _cache_service_errors_converter.convert(e) | |||
|
|
|||
| async def create_signing_key( | |||
| self, ttl_minutes: int, endpoint: str | |||
There was a problem hiding this comment.
I find it a little awkward to pass the endpoint as an arg here just to be re-packaged into CreateSigningKeyResponse and returned.
If you assign self._endpoint = endpoint in the ctor you can use that.
There was a problem hiding this comment.
This is the data plane endpoint, not the control plane endpoint. That's why I'm passing it differently here
virratanasangpunth
previously approved these changes
Apr 20, 2022
tylerburdsall
dismissed stale reviews from virratanasangpunth and wandaitzuchen
via
e44259f
kvcache
approved these changes
Apr 26, 2022
| self, ttl_minutes: int, endpoint: str | ||
| ) -> CreateSigningKeyResponse: | ||
| _validate_ttl_minutes(ttl_minutes) | ||
| try: |
There was a problem hiding this comment.
nit: You could make this code read a little nicer with a decorator so you're not copypasting try:except->converter.convert all over the place.
There was a problem hiding this comment.
Totally agree, happy to pick this up in a separate PR. Tracking this in #83 so we don't forget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for new APIs