chore: update READMEs and make api endpoint configurable in clients #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rishtigupta
reviewed
Aug 20, 2024
android/ModeratedChat/app/src/main/java/software/momento/kotlin/moderatedchat/MainActivity.kt
Outdated
Show resolved
Hide resolved
rishtigupta
reviewed
Aug 20, 2024
rishtigupta
reviewed
Aug 20, 2024
rishtigupta
reviewed
Aug 20, 2024
pgautier404
reviewed
Aug 20, 2024
Co-authored-by: pgautier404 <[email protected]>
anitarua
commented
Aug 20, 2024
rishtigupta
reviewed
Aug 20, 2024
|
|
||
| Once deployed, you can test your application using any of the client applications. | ||
|
|
||
| If you used the `API_DOMAIN="default"` option, you'll want to save the API gateway URL that was printed out. |
LGTM!
pgautier404
reviewed
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds readme generation workflow for the top-level README (can add for lower level ones if desired).
Updates the clients so that the API endpoint base url is a configurable environment variable rather than hardcoded since that value depends on the user's deployment setup. (Exception: I couldn't figure it out for the Android app so that one still directs users to hardcode it).
Ran each client locally to verify that they're all still working and the config changes worked.
Vercel preview deployments (available on PRs) use the preprod API endpoint now.
The prod Vercel deployment will use the prod API once this is merged to main.