feat: fetch metrics for the dynamo and elasticache resources #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruuuuuuuce
reviewed
Apr 1, 2024
| let metrics = | ||
| query_metrics_for_target(&metrics_client, Arc::clone(&limiter), metric_target).await?; | ||
| self.set_metrics(metrics); | ||
| self.set_metric_period_seconds(60 * 60 * 24); |
Change the get metadata functions for dynamo and elasticache to return a resource that will later be serialized into json. Add code for fetching metrics based on the dynamo and elasticache resources. Change the linter cli to print out the full json including the metrics.
Properly populate the region field in the resources.
Add progress bars/indicators for the different steps.
nand4011
force-pushed
the
aws-linter-metrics
branch
from
7527a71
to
f32a95f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the get metadata functions for dynamo and elasticache to return a resource that will later be serialized into json.
Add code for fetching metrics based on the dynamo and elasticache resources.
Change the linter cli to print out the full json including the metrics.