feat: initial implementation of get and set #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wraps the `RedisCodec` which converts to/from ByteBuffer. Because the Momento client accepts either byte arrays or Strings, we provide this wrapper for internal convenience.
We have a real test now!
Also updates the slf4j and logback versions.
Previoulsy gradle was caching test runs that completed. Since we run the tests with an environment variable to toggle redis vs momento, we do not want that behavior. We also enable logging.
Turn the redis tests into a single step vs a separate job.
cprice404
approved these changes
Aug 27, 2024
|
|
||
| @Override | ||
| public Mono<String> asking() { | ||
| return null; |
There was a problem hiding this comment.
just curious how we decided between returning null and throwing e.g. NotImplementedException? not a blocker for this PR but wondering what your thoughts are.
There was a problem hiding this comment.
I am going to throw an exception in a future PR. (mentioned at the bottom of the PR description :))
There was a problem hiding this comment.
Awesome, thanks. Sorry I missed that in the description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an initial implementation of the
MomentoRedisReactiveClientand integration tests:MomentoRedisReactiveClientwhich implements the Lettuce Reactive Redis command set interface. This is a client side proxy that takes a Momento cache client and cache name as dependencies in the constructor. Implements thegetandsetcommands in the first cut.MomentoRedisReactiveCommandswith the specific commands we have implemented. This allows a developer the confidence to only use the commands we have authored.RedisCodecwrapperRedisCodecByteArrayConverterfor Momento: Lettuce is generic over the key and value types, allowing a developer to use whatever they want, provided they pass aRedisCodecin the constructor to marshal/unmarshal the data toByteBuffer. Because Momento takesbyte[]and notByteBufferwe provide this wrapper for internal convenience.MomentoLettuceExceptionMapperto convert Momento exceptions back to Lettuce exceptions. The relevant exception type here is the timeout exception.BaseTestClasssets up the reactive client, which may be backed by either Lettuce or our Momento implementation. To toggle Redis vs Momento, setREDIS=1in the environment for Redis. The single test classScalarCommandTestshows how we have a single set of integration tests that can run.In a future PR we will update the other commands to throw an exception if not implemented.